Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Cursor#observeChanges calls with MongoDB change streams #1003

Draft
wants to merge 58 commits into
base: main
Choose a base branch
from
Draft

Replace Cursor#observeChanges calls with MongoDB change streams #1003

wants to merge 58 commits into from

Conversation

make-github-pseudonymous-again
Copy link
Contributor

@make-github-pseudonymous-again make-github-pseudonymous-again commented May 30, 2024 •
edited
Loading

@make-github-pseudonymous-again make-github-pseudonymous-again added feature/search This issue is about searching the data in general drop-meteor This has to do with replacing the Meteor framework with something else mongodb This has to do with MongoDB. labels May 30, 2024
@make-github-pseudonymous-again make-github-pseudonymous-again added the research This needs some research. label May 30, 2024
@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.94595% with 30 lines in your changes missing coverage. Please review.

Project coverage is 69.06%. Comparing base (28c94e2) to head (db10212).

Files Patch % Lines
imports/api/query/watch.ts 89.65% 3 Missing and 3 partials ⚠️
imports/api/createTagCollection.ts 37.50% 5 Missing ⚠️
imports/api/publication/publishCursors.tests.ts 96.03% 4 Missing ⚠️
imports/api/publication/stats/frequencyBySex.ts 95.00% 2 Missing and 1 partial ⚠️
imports/api/consultations.ts 87.50% 1 Missing and 1 partial ⚠️
imports/api/events.ts 0.00% 2 Missing ⚠️
imports/api/makeObservedQueryPublication.ts 80.00% 0 Missing and 2 partials ⚠️
imports/api/publication/define.ts 83.33% 2 Missing ⚠️
imports/api/makeFilteredCollection.ts 50.00% 1 Missing ⚠️
imports/api/publication/publishCursors.ts 96.42% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1003      +/-   ##
==========================================
+ Coverage   66.63%   69.06%   +2.43%     
==========================================
  Files         719      733      +14     
  Lines       10006    10653     +647     
  Branches     1349     1353       +4     
==========================================
+ Hits         6667     7358     +691     
+ Misses       2879     2833      -46     
- Partials      460      462       +2
Flag Coverage Δ
client 49.84% <83.10%> (+3.65%) ⬆️
server 60.11% <35.40%> (-2.53%) ⬇️
test 75.79% <94.39%> (+3.22%) ⬆️
test-app 54.13% <63.60%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1 branch from 54e6552 to a4392da Compare June 4, 2024 17:11
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1 branch from a4392da to be97498 Compare June 5, 2024 06:26
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1 branch from be97498 to b7c0e6d Compare June 5, 2024 14:55
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1 branch from a40b17b to e979365 Compare June 5, 2024 22:11
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1 branch from 092e57a to a2626fd Compare July 4, 2024 16:01
@make-github-pseudonymous-again
♻️ refactor(watch): Add enqueue typings.
bbacb30
@make-github-pseudonymous-again
🔬 test: Increase coverage of duplicates and unique.
ed9332f
@make-github-pseudonymous-again
♻️ refactor(publishCursors): Extract input validation function.
ffa8d46
@make-github-pseudonymous-again
👩‍💻 dx(tests): Allow to use undefined in template extras.
6764269
@make-github-pseudonymous-again
🩹 fix(frequencyBySex): Correctly handle patient deletion.
ad438f2
@make-github-pseudonymous-again
🔬 test(ui/stats/useFrequencyStats): Increase coverage.
4a04ee3
@make-github-pseudonymous-again
👩‍💻 dx(_test/fixtures): Add missing Meteor import.
ebf1571
@make-github-pseudonymous-again
👩‍💻 dx(Accounts): Remove rate limiting in all tests.
5e18e13 
Previously this was only disabled for `--full-app` tests.
@make-github-pseudonymous-again
♻️ refactor(frequencyBySex): Hide 0 counts to simplify testing.
f1915d9
@make-github-pseudonymous-again
🔬 test(useFrequencyStats): Cover patients updates.
d1884ae
@make-github-pseudonymous-again
👩‍💻 dx(tests): Add dropOwners fixture.
e1d48a8
@make-github-pseudonymous-again
🔬 test(useAvailability): Cover common usage.
cbb8810
@make-github-pseudonymous-again
👩‍💻 dx: Keep track of collections by name in a registry.
17c3b1c
@make-github-pseudonymous-again
👩‍💻 dx(tests): Increase timeout of appointments E2E tests.
57fcca1
@make-github-pseudonymous-again
🩹 fix(publishCursors): Correct collection mapping.
e109072 
We needed the Meteor.Collection object, not the raw collection.
@make-github-pseudonymous-again
🩹 fix: Actually use publishCursors in publications/define.
12f68d6
@make-github-pseudonymous-again
🔬 test(publishCursors): Increase coverage.
387e704
@make-github-pseudonymous-again
♻️ refactor(appointments): Make patient names optional for updates.
cc8f4c6
@make-github-pseudonymous-again
♻️ refactor(user): Update Account.createUser{Async} usage.
263f308
@make-github-pseudonymous-again
🔬 test(useNoShowsForPatient): Cover common usage.
bdbe099
@make-github-pseudonymous-again
🔬 test: Increase coverage target to 68%.
ce3e52b
@make-github-pseudonymous-again
♻️ refactor(publishCursors): Extract publishCursorObserver.
3912c1f
@make-github-pseudonymous-again
♻️ refactor(makeFilteredCollection): Leverage publishCursorObserver.
cb25469
@make-github-pseudonymous-again
🩹 fix(useSubscription): Set loading = false on stop/error.
3275a7f
@make-github-pseudonymous-again
👩‍💻 dx(events/intersects): Use silent error on bad input.
6983357
@make-github-pseudonymous-again
🔬 test(useIntersectingEvents): Cover common usage.
54dd72a
@make-github-pseudonymous-again
🩹 fix(useSubscription): Disable stale handles callbacks.
fea1722
@make-github-pseudonymous-again
🩹 fix(makeObservedQueryHook): Move updates to useEffect.
db10212
@make-github-pseudonymous-again make-github-pseudonymous-again force-pushed the refactor-use-change-streams-in-make-observed-query-publication-1 branch from 8b03ac7 to db10212 Compare July 27, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
drop-meteor This has to do with replacing the Meteor framework with something else feature/search This issue is about searching the data in general mongodb This has to do with MongoDB. research This needs some research.
Projects
MongoDB@next
Status: In progress
Milestone
Drop Meteor
Development

Successfully merging this pull request may close these issues.
1 participant
@make-github-pseudonymous-again